Remove zod schemas from app info JSON format #3458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
gonzaloriestra
approved these changes
Feb 20, 2024
|
Info isn't really a critical path, so as long as it basically works and the feature specs pass, we're OK. The main thing is the JSON is an accurate representation of the loaded app for debugging purposes. It's fair to ask whether we need the specifications at all, I'm not sure offhand. @isaacroldan thoughts? |
|
We don't need to output any info about the specifications, we can remove that :) |
amcaplan
force-pushed
the
remove-zod-schemas-from-app-json-info
branch
from
b4ea593
to
5fd1946
Compare
amcaplan
force-pushed
the
remove-zod-schemas-from-app-json-info
branch
from
5fd1946
to
3e4e398
Compare
Coverage report
Show files with reduced coverage 🔻
Test suite run success1569 tests passing in 736 suites. Report generated by 🧪jest coverage report action from 3e4e398 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
It's not valuable to the user, and it's 80% of output lines.
On a sample local app, we went from 2717 lines of JSON to 562.
WHAT is this pull request doing?
Removes the Zod schemas from app info when you run
--jsonHow to test your changes?
Compare
npm run info --jsonwith and without this change.Measuring impact
How do we know this change was effective? Please choose one:
Checklist
devordeployhave been reflected in the internal flowchart.